Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Inline Images #74

Closed
dapug opened this issue Nov 27, 2017 · 4 comments
Closed

Support Inline Images #74

dapug opened this issue Nov 27, 2017 · 4 comments

Comments

@dapug
Copy link
Contributor

dapug commented Nov 27, 2017

I see an Attach() method on FluentEmail.Core.Email, but no Inline attachment ability.

Business value:
This is important for email body's/templates that contain inline images (even for simple things like a company logo, so this is a pretty big deal).

Examples of MailGun supporting inline here:
https://documentation.mailgun.com/en/latest/api-sending.html#sending
https://documentation.mailgun.com/en/latest/user_manual.html#sending-via-api

@dapug
Copy link
Contributor Author

dapug commented Nov 27, 2017

Added PR for this. It would be nice to have in NuGet for my projects rather than my forked code. So an official release with this would be nice!

@dapug
Copy link
Contributor Author

dapug commented Nov 28, 2017

Now that I went to the effort, I'm thinking perhaps I jumped the gun on this. CID embedded image is 1 of 2 options for inline image, and its debatable that perhaps it's the less optimal way.

Read here for more:
https://sendgrid.com/blog/embedding-images-emails-facts/

Still, perhaps there are cases where it is critical?

@mxmissile
Copy link

I wish everyone would agree on a workable standard. The 3 options all have too many cons each.

@bjcull
Copy link
Collaborator

bjcull commented Dec 6, 2017

I'm happy with the solution being CID as it appears to be the most widely supported (if not outdated) solution. I'd personally go with using normal image tags, but it's good to get this support in as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants