Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

Renderflow exception on iOS simulator #10

Closed
DK15 opened this issue Jan 8, 2019 · 6 comments
Closed

Renderflow exception on iOS simulator #10

DK15 opened this issue Jan 8, 2019 · 6 comments

Comments

@DK15
Copy link
Contributor

DK15 commented Jan 8, 2019

I was playing around this app to add my profile and observed renderflow exception on iOS simulator(iphone 8 - 11.4) under GroovinChip -> Pub Packages -> groovin_widgets, as below:
screen shot 2019-01-08 at 2 26 20 pm

I've a fix for it : to wrap Text widget inside Flexible widget which resolves issue, as below:

screen shot 2019-01-08 at 2 31 00 pm

I am unable to push my changes, as I am getting this error while creating pr:

remote: Permission to lukepighetti/flutter-developers.git denied to DK15.
fatal: unable to access 'https://github.com/lukepighetti/flutter-developers.git/': The requested URL returned error: 403

@lukepighetti
Copy link
Owner

@GroovinChip

@lukepighetti
Copy link
Owner

lukepighetti commented Jan 8, 2019

Not sure why you cannot make a PR. Did you try forking it to your account first before making a PR? Thanks for bringing up the issue. :)

@DK15
Copy link
Contributor Author

DK15 commented Jan 8, 2019

yeah I tried that by forking earlier but for some reason it gave me same error, but I think I figured it out now. It had to do something with my login credentials.
Is it ok if I raise pr for the fix ?

@GroovinChip
Copy link
Contributor

You can submit the fix, thanks for pointing it out

@DK15
Copy link
Contributor Author

DK15 commented Jan 8, 2019

Thanks @GroovinChip and @lukepighetti , I raised the PR.

@lukepighetti
Copy link
Owner

PR accepted, thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants