New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for generic persistence interface -- alternative 1 #27
Add support for generic persistence interface -- alternative 1 #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done @solid-yuriiprykhodko! I've added a couple of comments - please review and let me know what you think. Great addition to the hydrated plugin.
cc @solid-software
Coverage HTML report: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @solid-yuriiprykhodko !
Resolves #23
Alternative to #26
Abstracts away only the key-value store.
The persistence
key
and also thehydrate
andpersist
callbacks are kept in theHydratedSubject
class, avoiding breaking changes.