Add support for generic persistence interface -- alternative 1 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solid-software
suggested changes
Aug 20, 2021
Collaborator
solid-software
left a comment
solid-software
left a comment
There was a problem hiding this comment.
Nicely done @solid-yuriiprykhodko! I've added a couple of comments - please review and let me know what you think. Great addition to the hydrated plugin.
Contributor
Author
|
cc @solid-software Coverage HTML report: |
solid-software
approved these changes
Aug 26, 2021
Collaborator
solid-software
left a comment
solid-software
left a comment
There was a problem hiding this comment.
LGTM - thanks @solid-yuriiprykhodko !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #23
Alternative to #26
Abstracts away only the key-value store.
The persistence
keyand also thehydrateandpersistcallbacks are kept in theHydratedSubjectclass, avoiding breaking changes.