merge DefaultTextTheme instead of creating a new TextStyle #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -137,7 +137,7 @@ class SalomonBottomBar extends StatelessWidget { | |||
| : EdgeInsets.only( | |||
| left: itemPadding.left, | |||
| right: itemPadding.right / 2), | |||
| child: DefaultTextStyle( | |||
| child: DefaultTextStyle.merge( | |||
| style: TextStyle( | |||
There was a problem hiding this comment.
I think DefaultTextStyle is sufficient in this case. DefaultTextStyle.merge could also be used in this case, but it would only be necessary if some of the Text widgets in the subtree have an explicit style set that needs to be merged with the default style. So DefaultTextStyle is sufficient since there is only one Text widget in the given code,.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.