Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double encoding of image_link #19

Closed
pmhou opened this issue May 8, 2017 · 0 comments
Closed

Double encoding of image_link #19

pmhou opened this issue May 8, 2017 · 0 comments

Comments

@pmhou
Copy link
Contributor

pmhou commented May 8, 2017

When a variant is created, the already processed image_link node is encoded a 2nd time with safeCharEncodeURL() which produces a double encoded string. Namely ' ' (space) becomes %20 which then becomes %2520.

To fix this, I've used urldecode() on the image link string before it is ran through safeCharEncodeURL()

// src/LukeSnowden/GoogleShoppingFeed/Item.php:177
$imageLink = $this->safeCharEncodeURL(urldecode($imageLink);

Fix applied to #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants