Add tests; make some minor code changes #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes default
returnopt
to FALSE and actually returns it when the user wants it. We could remove this later if we want, but I think returning thevalue
and the optim metadata is useful for people trying different hyperparameters.Makes the package overall a bit more CRAN friendly. Much more has to be done here, but just in terms of how we import, export, and register functions. This is because the previous solution throws warnings in R CMD check, which will slow down CRAN submission. Note, it looks like someone already did this in July for the main branch of KRLS to keep it on CRAN.
Adds tests. The important one demonstrates that indeed the analytical gradient and hessian we have in the .cpp are correct, using numerical derivatives to test. You can see this in
tests/testthat/test_krlogit_fns.R
Extends our CI to include test coverage and more R releases and operating systems.