Conversion to NET Standard 2.0 #22
Conversation
Converted StatsdClient to .NETStandard 2.0 Updated StatsdClientTests to 4.6.1
StatsdClient/StatsdClient.nuspec
Outdated
| @@ -3,7 +3,7 @@ | |||
| <metadata> | |||
| <id>StatsdCsharpClient</id> | |||
| <version>$version$</version> | |||
| <title>Simple Statsd Client for .Net 4.5</title> | |||
| <title>Simple Statsd Client for .Net 4.6.1</title> | |||
There was a problem hiding this comment.
Can we just call this Simple StatsD Client
There was a problem hiding this comment.
Can't see why not. I will make the change in the next few days.
| @@ -8,14 +8,15 @@ | |||
| <AppDesignerFolder>Properties</AppDesignerFolder> | |||
| <RootNamespace>StatsdClientTests</RootNamespace> | |||
| <AssemblyName>StatsdClientTests</AssemblyName> | |||
| <TargetFrameworkVersion>v4.5</TargetFrameworkVersion> | |||
| <TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion> | |||
There was a problem hiding this comment.
Can we update this to run on .net core 2.0 (xplat) and ditch configuration?
There was a problem hiding this comment.
Sure. I will update the project and commit it along with the previous request.
Updated unit test library to .NET Core 2.0. Fixed name violation by updating count_SendToStatsd_Success to Count_SendToStatsd_Success. Changed Count_SendToStatsd_Success return type to void, as per other tests. Cleaned up unused using statements. Version up libraries and updated change log.
|
Thanks for the PR! Can you please try reviewing the other pr as well and hopefully we can get this out with more changes. |
|
You are welcome. I took a brief look at the other pr and these are my thoughts. Basically this means that the only class that needs/could to be merged in would be Statsd.cs. However there are a number of conflicts here that mean that this would need to be a manual merge. In my opinion, it would be better for the author to start over with a clean version of the source. |
Conversion of the StatsdClient library to .NET Standard 2.0 so that it can be reference for use by either .NET Framework (4.6.1) or .NET Core applications.