Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pages] Add Recovery Codes and WebAuthn #23

Merged
merged 12 commits into from
Feb 9, 2023

Conversation

cwildfoerster
Copy link
Contributor

Added support for webauthn and recovery codes, based on keycloak base template. Haven't touched the frontend javascript code much, just for jQuery(...) instead of $(...), could be moved to the main script, but may need some refactoring due to alot of freemarker "injected" variabled into the code.

webauthn login

Bildschirmfoto vom 2022-11-08 15-19-05

Adding recovery codes:

Bildschirmfoto vom 2022-11-08 15-20-24

Authenticator selector

Bildschirmfoto vom 2022-11-08 15-19-45

@lukin
Copy link
Owner

lukin commented Nov 13, 2022

Thanks for your contribution. 🙂

There are some issues that need to be resolved before this PR is merged.

  • As you already pointed out, remove jQuery.
  • Import all this JS code from a separate file only for the required pages.
  • Use components instead of repeating button classes.

I'll try to find time for this.

@cwildfoerster
Copy link
Contributor Author

Thank you for your input, i'm no frontend dev, but i may try the JS stuff. For now, i just created a secondarySmall button component.

@fbrettnich
Copy link

merge?

@matt01 matt01 mentioned this pull request Jan 3, 2023
@Gurkengewuerz
Copy link

What is the current state? Can we help somehow? 👀

@lukin
Copy link
Owner

lukin commented Feb 2, 2023

Most of the client code is rewritten in TypeScript following the example of the Recovery Codes pages. I would welcome any help in testing this next week.

@Gurkengewuerz
Copy link

Sure. Just comment on this when it's ready 🙌🏼

@lukin lukin changed the title add support for webauthn and recovery codes [pages] Add Recovery Codes and WebAuthn Feb 5, 2023
@lukin lukin merged commit 233267b into lukin:master Feb 9, 2023
@Gurkengewuerz
Copy link

Sorry that I had not found time so far. I am writing my bachelor thesis currently. Tested it after i saw your notification and lgtm.

lukin added a commit that referenced this pull request Oct 24, 2023
Co-authored-by: Anthony Lukin <anthony@lukin.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants