[pages] Add Error, Login Page Expired, and Terms #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, forget what I just said about the login expired page. This might be better:
|
|
Hey @dschemp 👋 Thanks for your pull request. Looks good. You are right. "Click here" links provide poor UX. I also want to think about how to improve it. |
|
Is it possible to merge this? Missing the terms page right now |
lukin
changed the title
lukin
added a commit
that referenced
this pull request
Oct 24, 2023
Co-authored-by: Anthony Lukin <anthony@lukin.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I previously forked this project for some customization but don't have time and needs to maintain it. I tried to adapt a couple of pages to this project.
This includes (for now) the error page, the login expired page and the TaC page:
I am a bit unhappy about the login expired page and maybe you have some ideas on how to make it look good. ^^
Thanks in advance!