Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake v3.21.2 #31

Merged
merged 2 commits into from
Sep 2, 2021
Merged

cmake v3.21.2 #31

merged 2 commits into from
Sep 2, 2021

Conversation

garethsb
Copy link
Contributor

@garethsb garethsb commented Sep 2, 2021

Just did a search & replace!

@garethsb
Copy link
Contributor Author

garethsb commented Sep 2, 2021

coverallsapp error looks similar to coverallsapp/github-action#26

@lukka
Copy link
Owner

lukka commented Sep 2, 2021

Just did a search & replace!

Thanks for the contribution! You need to regenerate the files in /dist/, by running npm run pack and commit all changed files..

About the coverall error, hopefully it is only a server side error? And may go away sooner orlater? I have not checked it out yet.

@garethsb
Copy link
Contributor Author

garethsb commented Sep 2, 2021

OK, I've just tried that. I had already made the change to /dist/index.js. The only other change was to the /package-lock.json, which I've now committed.

The instructions at https://github.com/lukka/get-cmake#developers-information didn't work for me though. I had to npm install gulp, not gulp4, and do it locally not globally, in order for npm run pack and then npm run test to work.

@lukka
Copy link
Owner

lukka commented Sep 2, 2021

OK, I've just tried that. I had already made the change to /dist/index.js. The only other change was to the /package-lock.json, which I've now committed.

The instructions at https://github.com/lukka/get-cmake#developers-information didn't work for me though. I had to npm install gulp, not gulp4, and do it locally not globally, in order for npm run pack and then npm run test to work.

Ok, a PR for refreshing the instructions would be good as well!

@lukka lukka merged commit 2e45cd8 into lukka:main Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants