Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache key doesn't seem to include triplet #27

Closed
PazerOP opened this issue Jun 30, 2020 · 2 comments · Fixed by #28
Closed

Cache key doesn't seem to include triplet #27

PazerOP opened this issue Jun 30, 2020 · 2 comments · Fixed by #28
Labels
enhancement New feature or request

Comments

@PazerOP
Copy link

PazerOP commented Jun 30, 2020

I haven't done extensive testing to verify this is the case, but it seems to me that the cache key doesn't take the value of vcpkgTriplet into account. Given the following:

    - name: run-vcpkg
      uses: lukka/run-vcpkg@v3.0
      with:
        vcpkgGitCommitId: 7192d3affa4b1d8f88e3e730eb561612c24f7d78
        vcpkgArguments: 'SDL2 openSSL glbinding cpp-httplib libzippp cppcoro'
        vcpkgTriplet: ${{ matrix.triplet }}

If I have x86-windows and x64-windows in my matrix, it seems like they both try to save under the same cache key. This means that every time the workflow is triggered, one of them gets rebuilt, since they are stepping on each other. I added appendedCacheKey: "42-pazer-${{ matrix.triplet }}" and it seemed to resolve the issue.

@lukka
Copy link
Owner

lukka commented Jun 30, 2020

@PazerOP yes, I think adding vcpkgTriplet input content to the cache's key is helpful.
Also, as suggested here I would recommend the usage of the response file, which contains both packages and triplet, and 'vcpkg as a submodule', so you do not have to specify anything in the workflow other than the reponse file.

@lukka lukka added the enhancement New feature or request label Jun 30, 2020
@PazerOP
Copy link
Author

PazerOP commented Jul 1, 2020

Thanks, I'm aware of the response file suggestion, but this solution meets my needs for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants