-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest Mode and Recursive Submodules #67
Comments
@spinicist yes, it could be done, at the moment only first level submodules are taken into account. At the very end, it's best to tailor the workflow to your need by using directly the tools you really need and that you can run and test directly on your box rather than relying on GitHub actions. Please have a look to how to create a workflow without (too many) GitHub actions in here: lukka/run-cmake#41 The idea is that GitHub actions are useful only if strictly necessary and fit your purpose. |
I agree overall - but specifically with regards to persisting vcpkg's cache, I have no idea how to do that without an action! (The rest of my build can be described in a 3 line shell script which is actually how I do it on my machine). |
@spinicist i'll take a note about the added values of this GitHub action: automatic cache "done right". Note that (quite ridiculously) the action/cache is broken regarding the path exclusion, which makes the created cache to be gigantic :/ |
Thanks! |
Hello,
I wanted to try the new manifest mode cacheing but hit a problem. I recently changed the way I include vcpkg in my repos - it is now a submodule of a submodule. My repo structure now looks like:
which you can see for real here: https://github.com/spinicist/riesling/tree/tests. I ended up with this structure after discussing with some vcpkg engineers how best to include Address Sanitizer.
run-vcpkg
fails to detect that vcpkg is a sub-module in this situation, and gives this error message:run-vcpkg action execution failed: 'Error: 'vcpkgGitCommitId' input parameter must be provided when the specified vcpkg directory (/home/runner/work/riesling/riesling/cmake/vcpkg) is not a submodule.
However if I provide a vcpkg commit ID, I then get the following error:
Run logs in both situations can be found here: https://github.com/spinicist/riesling/actions/runs/449601569 and here: https://github.com/spinicist/riesling/runs/1619416104.
Is there a way
run-vcpkg
can be made aware of recursive submodules?The text was updated successfully, but these errors were encountered: