OSSM-2419 Prevent deadlock between multiNamespaceInformer.lock and na…

…mespaceSet.lock (maistra#35)
luksa · Jan 11, 2023 · 552cae7 · 552cae7
1 parent 3ae7b65
commit 552cae7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pkg/informers/informer.go b/pkg/informers/informer.go
@@ -262,13 +262,13 @@ func (i *multiNamespaceInformer) AddIndexers(indexers cache.Indexers) error {
 
 // HasSynced checks if each namespaced informer has synced.
 func (i *multiNamespaceInformer) HasSynced() bool {
-	i.lock.Lock()
-	defer i.lock.Unlock()
-
 	if !i.namespaces.Initialized() {
 		return false
 	}
 
+	i.lock.Lock()
+	defer i.lock.Unlock()
+
 	for _, informer := range i.informers {
 		if synced := informer.HasSynced(); !synced {
 			return false