feat: add increaseAllowance + decreaseAllowance functions to LSP7
#592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hello ⛽📊 See Gas Benchmark report of Using UniversalProfile owned by an EOA🔀
|
execute scenarios - 👑 UP Owner |
⛽ Gas Usage |
|---|---|
| Transfer 1 LYX to an EOA without data | 37570 |
| Transfer 1 LYX to a UP without data | 36672 |
| Transfer 1 LYX to an EOA with 256 bytes of data | 42231 |
| Transfer 1 LYX to a UP with 256 bytes of data | 44771 |
| Transfer 0.1 LYX to 3x EOA without data | 70967 |
| Transfer 0.1 LYX to 3x UP without data | 75785 |
| Transfer 0.1 LYX to 3x EOA with 256 bytes of data | 84955 |
| Transfer 0.1 LYX to 3x EOA with 256 bytes of data | 100147 |
🗄️ setData scenarios
setData scenarios - 👑 UP Owner |
⛽ Gas Usage |
|---|---|
| Set a 20 bytes long value | 49996 |
| Set a 60 bytes long value | 95318 |
| Set a 160 bytes long value | 164456 |
| Set a 300 bytes long value | 279681 |
| Set a 600 bytes long value | 484069 |
| Change the value of a data key already set | 32884 |
| Remove the value of a data key already set | 27348 |
| Set 2 data keys of 20 bytes long value | 78478 |
| Set 2 data keys of 100 bytes long value | 260606 |
| Set 3 data keys of 20 bytes long value | 105208 |
| Change the value of three data keys already set of 20 bytes long value | 45520 |
| Remove the value of three data keys already set | 41380 |
🗄️ Tokens scenarios
Tokens scenarios - 👑 UP Owner |
⛽ Gas Usage |
|---|---|
| Minting a LSP7Token to a UP (No Delegate) from an EOA | 91375 |
| Minting a LSP7Token to an EOA from an EOA | 59232 |
| Transferring an LSP7Token from a UP to another UP (No Delegate) | 98976 |
| Minting a LSP8Token to a UP (No Delegate) from an EOA | 158331 |
| Minting a LSP8Token to an EOA from an EOA | 126188 |
| Transferring an LSP8Token from a UP to another UP (No Delegate) | 147520 |
📝 Notes
- The
executeandsetDatascenarios are executed on a fresh UniversalProfile smart contract, deployed as standard contracts (not as proxy behind a base contract implementation).
⛽📊 See Gas Benchmark report of Using UniversalProfile owned by an LSP6KeyManager
This document contains the gas usage for common interactions and scenarios when using UniversalProfile smart contracts.
🔀 execute scenarios
👑 unrestricted controller
execute scenarios - 👑 main controller |
⛽ Gas Usage |
|---|---|
| transfer LYX to an EOA | 60786 |
| transfer LYX to a UP | 62388 |
| transfer tokens (LSP7) to an EOA (no data) | 107651 |
| transfer tokens (LSP7) to a UP (no data) | 243913 |
| transfer a NFT (LSP8) to a EOA (no data) | 171495 |
| transfer a NFT (LSP8) to a UP (no data) | 291110 |
🛃 restricted controller
execute scenarios - 🛃 restricted controller |
⛽ Gas Usage |
|---|---|
| transfer some LYXes to an EOA - restricted to 1 x allowed address only (TRANSFERVALUE + 1x AllowedCalls) | 73025 |
| transfers some tokens (LSP7) to an EOA - restricted to LSP7 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data) | 123457 |
| transfers some tokens (LSP7) to an other UP - restricted to LSP7 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data) | 259719 |
| transfers a NFT (LSP8) to an EOA - restricted to LSP8 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data) | 187289 |
| transfers a NFT (LSP8) to an other UP - restricted to LSP8 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data) | 306904 |
🗄️ setData scenarios
👑 unrestricted controller
setData scenarios - 👑 main controller |
⛽ Gas Usage |
|---|---|
| updates profile details (LSP3Profile metadata) | 137154 |
| give permissions to a controller (AddressPermissions[] + AddressPermissions[index] + AddressPermissions:Permissions:) | 133229 |
| restrict a controller to some specific ERC725Y Data Keys | 139498 |
| restrict a controller to interact only with 3x specific addresses | 162202 |
| remove a controller (its permissions + its address from the AddressPermissions[] array) | 68186 |
| write 5x LSP12 Issued Assets | 233651 |
🛃 restricted controller
setData scenarios - 🛃 restricted controller |
⛽ Gas Usage |
|---|---|
setData(bytes32,bytes) -> updates 1x data key |
102880 |
setData(bytes32[],bytes[]) -> updates 3x data keys (first x3) |
161780 |
setData(bytes32[],bytes[]) -> updates 3x data keys (middle x3) |
145823 |
setData(bytes32[],bytes[]) -> updates 3x data keys (last x3) |
171008 |
setData(bytes32[],bytes[]) -> updates 2x data keys + add 3x new controllers (including setting the array length + indexes under AddressPermissions[index]) |
250352 |
📝 Notes
- The
executeandsetDatascenarios are executed on a fresh UniversalProfile and LSP6KeyManager smart contracts, deployed as standard contracts (not as proxy behind a base contract implementation).
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
skimaharvey
approved these changes
May 16, 2023
Co-authored-by: Skima Harvey <64636974+skimaharvey@users.noreply.github.com>
YamenMerhi
approved these changes
May 17, 2023
|
@skimaharvey Most of the ERC20 functions return bool by design, we don't. To keep consistency, |
b00ste
approved these changes
May 17, 2023
Merged
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR introduce?
🐛 Bug
In
LSP7DigitalAssetCore, add the functionsincreaseAllowanceanddecreaseAllowancesimilar to the OpenZeppelin implementation from OpenZeppelin to limit the reduce of allowance double spend.🧪 Tests
Test both functions similarly to the test suite from OpenZeppelin: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/1642b6639b93e3b97be163d49827e1f56b81ca11/test/token/ERC20/ERC20.test.js#L133
### Fixes:
lukso-network/LIPs#112
PR Checklist
npm run linter(solhint)npm run format(prettier)npm run buildnpm run test