Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: change set/get TokenId function name in LSP8 and LSP8TokenIdSchema to LSP8TokenIdFormat #822

Merged
merged 12 commits into from
Dec 6, 2023

Conversation

YamenMerhi
Copy link
Member

What does this PR introduce?

⚠️ BREAKING CHANGES

♻️ Refactor

  • Change LSP8TokenIdSchema to LSP8TokenIdFormat
  • Change set/getTokenIdData/Batch to set/getData|Batch|ForTokenId

PR Checklist

  • Wrote Tests
  • Wrote & Generated Documentation (readme/natspec/dodoc)
  • Ran npm run lint && npm run lint:solidity (solhint)
  • Ran npm run format (prettier)
  • Ran npm run build
  • Ran npm run test

Copy link
Contributor

github-actions bot commented Dec 5, 2023

👋 Hello
⛽ I am the Gas Bot Reporter. I keep track of the gas costs of common interactions using Universal Profiles 🆙 !
📊 Here is a summary of the gas cost with the code introduced by this PR.

⛽📊 Gas Benchmark Report

Deployment Costs

Deployed contracts ⛽ Deployment cost
UniversalProfile 3168335 (0 )
KeyManager 3659015 (0 )
LSP1DelegateUP 1637510 (0 )
LSP7Mintable 2407823 (0 )
LSP8Mintable 2809933 (36 📈❌)

Runtime Costs

UniversalProfile owned by an 🔑 EOA

🔀 execute scenarios

execute scenarios - UP owned by 🔑 EOA ⛽ Gas Usage
Transfer 1 LYX to an EOA without data 37572 (0 )
Transfer 1 LYX to a UP without data 46265 (0 )
Transfer 1 LYX to an EOA with 256 bytes of data 42245 (36 📈❌)
Transfer 1 LYX to a UP with 256 bytes of data 57198 (24 📈❌)
Transfer 0.1 LYX to 3x EOA without data 70898 (0 )
Transfer 0.1 LYX to 3x UP without data 104489 (0 )
Transfer 0.1 LYX to 3x EOA with 256 bytes of data 84850 (-48 📉✅)
Transfer 0.1 LYX to 3x UPs with 256 bytes of data 137281 (36 📈❌)

🗄️ setData scenarios

setData scenarios - UP owned by 🔑 EOA ⛽ Gas Usage
Set a 20 bytes long value 49921 (0 )
Set a 60 bytes long value 95243 (0 )
Set a 160 bytes long value 164403 (-12 📉✅)
Set a 300 bytes long value 279284 (12 📈❌)
Set a 600 bytes long value 486656 (-12 📉✅)
Change the value of a data key already set 32809 (0 )
Remove the value of a data key already set 27283 (0 )
Set 2 data keys of 20 bytes long value 78440 (12 📈❌)
Set 2 data keys of 100 bytes long value 260592 (-12 📉✅)
Set 3 data keys of 20 bytes long value 105128 (0 )
Change the value of three data keys already set of 20 bytes long value 45428 (0 )
Remove the value of three data keys already set 41325 (0 )

🗄️ Tokens scenarios

Tokens scenarios - UP owned by 🔑 EOA ⛽ Gas Usage
Minting a LSP7Token to a UP (No Delegate) from an EOA 93114 (0 )
Minting a LSP7Token to an EOA from an EOA 59390 (0 )
Transferring an LSP7Token from a UP to another UP (No Delegate) 102367 (0 )
Minting a LSP8Token to a UP (No Delegate) from an EOA 159961 (0 )
Minting a LSP8Token to an EOA from an EOA 126238 (0 )
Transferring an LSP8Token from a UP to another UP (No Delegate) 151083 (22 📈❌)
UniversalProfile owned by a 🔒📄 LSP6KeyManager

🔀 execute scenarios

execute scenarios 👑 main controller 🛃 restricted controller
LYX transfer --> to an EOA 64365 (0 ) 75316 (0 )
LYX transfer --> to a UP 78508 (0 ) 93410 (0 )
LSP7 token transfer --> to an EOA 116872 (0 ) 131622 (0 )
LSP7 token transfer --> to a UP 250518 (0 ) 265268 (0 )
LSP8 NFT transfer --> to an EOA 180981 (44 📈❌) 195731 (44 📈❌)
LSP8 NFT transfer --> to a UP 297829 (66 📈❌) 312579 (66 📈❌)

🗄️ setData scenarios

setData scenarios 👑 main controller 🛃 restricted controller
Update Profile details (LSP3Profile Metadata) 67264 (0 ) 77286 (0 )
Add a new controller with permission to SET_DATA + 3x allowed data keys:
AddressPermissions[]
+ AddressPermissions[index]
+ AddressPermissions:Permissions:<controller>
+ AddressPermissions:AllowedERC725YDataKeys:<controller)
209516 (0 ) 219673 (0 )
Update permissions of previous controller. Allow it now to SUPER_SETDATA 52292 (0 ) 55298 (0 )
Remove a controller:
1. decrease AddressPermissions[] Array length
2. remove the controller address at AddressPermissions[index]
3. set "0x" for the controller permissions under AddressPermissions:Permissions:
78765 (0 ) 90064 (0 )
Write 5x new LSP12 Issued Assets 66959 (0 ) 101586 (0 )
Update 3x data keys (first 3) 125411 (0 ) 159515 (0 )
Update 3x data keys (middle 3) 105499 (0 ) 143669 (0 )
Update 3x data keys (last 3) 125411 (0 ) 169002 (0 )
Set 2 x new data keys + add 3x new controllers 810121 (0 ) 871921 (0 )

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Changes to gas cost

Generated at commit: c9bde14a2c5570d93c503da05b72a7baa62cd355, compared to commit: 3e1156e49202ac2db618bc6e5841afe860c7f0a8

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
LSP6ExecuteUnrestrictedController transferNFTToRandomEOA +35 ❌ +0.02%
LSP6ExecuteRestrictedController transferNFTToRandomEOA +35 ❌ +0.02%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
LSP6ExecuteUnrestrictedController 3,047,114 (0) transferNFTToRandomEOA
transferNFTToRandomUP
142,070 (+35)
247,992 (+53)
+0.02%
+0.02%
142,070 (+35)
247,992 (+53)
+0.02%
+0.02%
142,070 (+35)
247,992 (+53)
+0.02%
+0.02%
142,070 (+35)
247,992 (+53)
+0.02%
+0.02%
1 (0)
1 (0)
LSP6ExecuteRestrictedController 3,047,114 (0) transferNFTToRandomEOA
transferNFTToRandomUP
143,326 (+35)
249,248 (+53)
+0.02%
+0.02%
143,326 (+35)
249,248 (+53)
+0.02%
+0.02%
143,326 (+35)
249,248 (+53)
+0.02%
+0.02%
143,326 (+35)
249,248 (+53)
+0.02%
+0.02%
1 (0)
1 (0)

Copy link
Member

@CJ42 CJ42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added review comments

constants.ts Outdated Show resolved Hide resolved
Copy link
Member

@CJ42 CJ42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change the constant name in constants.ts

It is still called LSP8_TOKEN_ID_SCHEMA

constants.ts Outdated Show resolved Hide resolved
@CJ42 CJ42 merged commit 2bf84f6 into develop Dec 6, 2023
43 checks passed
@CJ42 CJ42 deleted the nameChange branch December 6, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants