Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get deployed contract addresses from event logs #192

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

CallumGrindle
Copy link
Contributor

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

fix

What is the current behaviour (you can also link to an open issue here)?

Deployed contract addresses do not get passed properly as they are no longer available in the contractAddress property of the receipt

What is the new behaviour (if this is a feature change)?

Gets the contract addresses from the event logs

Other information:

@codecov-commenter
Copy link

Codecov Report

Merging #192 (9f5085b) into develop (edb0c5e) will decrease coverage by 0.39%.
The diff coverage is 6.06%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop     #192      +/-   ##
===========================================
- Coverage    19.72%   19.34%   -0.39%     
===========================================
  Files           16       16              
  Lines         1034     1070      +36     
  Branches       358      371      +13     
===========================================
+ Hits           204      207       +3     
- Misses         808      840      +32     
- Partials        22       23       +1     
Impacted Files Coverage Δ
src/lib/services/digital-asset.service.ts 6.63% <0.00%> (-0.11%) ⬇️
src/lib/services/key-manager.service.ts 17.14% <0.00%> (-0.51%) ⬇️
src/lib/services/universal-profile.service.ts 15.34% <0.00%> (-0.37%) ⬇️
src/lib/helpers/deployment.helper.ts 21.55% <7.14%> (-4.83%) ⬇️
src/lib/helpers/config.helper.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@richtera richtera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a locally linked test-app to successfully deploy an LSP7 asset.

@CallumGrindle CallumGrindle merged commit 420efd0 into develop Mar 30, 2023
@CallumGrindle CallumGrindle deleted the fix-contract-deployment branch March 30, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants