Fix source map #211
Merged
Fix source map #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #211 +/- ##
===========================================
+ Coverage 19.34% 19.53% +0.18%
===========================================
Files 16 15 -1
Lines 1070 1065 -5
Branches 371 373 +2
===========================================
+ Hits 207 208 +1
+ Misses 840 834 -6
Partials 23 23 see 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
richtera
approved these changes
Aug 19, 2023
CallumGrindle
approved these changes
Aug 21, 2023
CallumGrindle
suggested changes
Aug 21, 2023
Hugoo
reviewed
Aug 21, 2023
magalimorin18
force-pushed
the
fix-source-map
branch
from
a341b73
to
e3c60b3
Compare
CallumGrindle
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
This PR introduce source map.
What is the current behaviour (you can also link to an open issue here)?
When on a dapp an issue comes from the lsp-factory library, it s not possible to have a look at the typescript file of the library.
What is the new behaviour (if this is a feature change)?
We can access the typescript file of the library from the browser of the dapp.
Other information:
It was a real concern for me that activating inline source map increases the weight of the library
(From 990kB to 1.2 MB) as we want our library to be as light as possible.
On this topic Andrea said that
"There is currently really no other way. Normally the consumer of the library should just be able to work with the source code if we had a real language".