Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added feature to enable using without defmt #9

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

BartMassey
Copy link
Contributor

Currently this crate depends on defmt, and uses feature embassy-nrf/defmt. The dependency on heapless appears to be missing.

This PR adds the dependency on heapless, and adds a default defmt feature to this crate that depends on defmt, embassy-nrf/defmt and heapless/defmt-03.

As a result, this crate will not depend on defmt when built with --no-default-features.

I needed this to try switching from defmt to rtt-target on my crate. Unlike stock defmt, rtt-target works well with cargo-embed.

Copy link
Owner

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left one comment

Cargo.toml Outdated Show resolved Hide resolved
@lulf lulf merged commit 70c1fce into lulf:main Mar 14, 2024
1 check passed
@BartMassey
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants