Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark button not saving bookmarks when recording is finished. #169

Open
MrMK0R opened this issue Jan 7, 2024 · 3 comments
Open

Bookmark button not saving bookmarks when recording is finished. #169

MrMK0R opened this issue Jan 7, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@MrMK0R
Copy link

MrMK0R commented Jan 7, 2024

I am not sure if this is the intended use for the bookmark feature, but when recording, and hitting the bookmark shortcut, the bookmark doesn't show in the video.

Steps:
1 - bind bookmark button and enable bookmarks
2 - start game with recording
3 - make a play and hit bookmark button
4 - end recording
5 - Bookmarks added during recording don't show in video preview.

@Segergren
Copy link
Contributor

Can you attach the logs?

@MrMK0R
Copy link
Author

MrMK0R commented Jan 8, 2024

Here is current log
logs.txt

@lulzsun
Copy link
Owner

lulzsun commented Jan 8, 2024

It looks like it properly registers the keybind on press, so this issue might be related to how we are currently storing bookmarks in localStorage of the WebView.

If we complete #84, this may solve the issue. I might get around doing that soon, but no promises.

@lulzsun lulzsun added the bug Something isn't working label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants