Save state

[BeckySharp]

As with previous PRs and the discussion, there the engine adds the mentions to its state, the State lasts the life of the Engine, and optionally can be persisted or dumped.

• Not all methods are in place (e.g., some SQLState methods and the jsonlines serialization of Mentions)
• I'd like someone to check/help write tests for the Ordering adaptation for Mentions vs ResultsItems in MemoryState (for the TreeSet)
• I removed the StateFactory (didn't seem necessary)
• I put the ResultsIterator in the MentionFactory, since the Iterator creation is where the Mentions get built, so the MentionFactory seemed like a good place to do it
• I passed the IndexSearcher to SQLState. This is because the LazyIdGetter needs access to the IndexSearcher, and that's needed to make Mentions, and the SQLState essentially re-makes mentions when asked to "getAll/Some"

Please review and we can discuss!! :)

[BeckySharp]

for the sake of a single state branch, merging

[kwalcock]

These squashing merges aren't working for me at all. Based on the commit messages alone, this is where the code has ended up and where new code should be added. This branch also very much needs a different name.

[kwalcock]

I can rename if this is the place to do it. How about stateV2?

[BeckySharp]

yes, that's good. I think this branch is going to be the "working branch" for the state

…

On Thu, Sep 24, 2020 at 8:42 PM Keith Alcock ***@***.***> wrote: *External Email* I can rename if this is the place to do it. How about stateV2? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#205 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJCPCMG4SMSKQOTORLCIVLSHQGS7ANCNFSM4RT3LILA> .