unused parameters and naked returns

lum-network · Jun 14, 2023 · 517fc9c · 517fc9c
1 parent a3cb5e0
commit 517fc9c
Show file tree

Hide file tree

Showing 5 changed files with 39 additions and 39 deletions.
diff --git a/x/airdrop/keeper/hooks.go b/x/airdrop/keeper/hooks.go
@@ -8,7 +8,7 @@ import (
 	"github.com/lum-network/chain/x/airdrop/types"
 )
 
-func (k Keeper) AfterProposalVote(ctx sdk.Context, proposalID uint64, voterAddr sdk.AccAddress) {
+func (k Keeper) AfterProposalVote(ctx sdk.Context, _ uint64, voterAddr sdk.AccAddress) {
 	_, _, err := k.ClaimCoinsForAction(ctx, voterAddr, types.ACTION_VOTE)
 	if err != nil {
 		panic(err.Error())
@@ -38,50 +38,50 @@ func (k Keeper) Hooks() Hooks {
 	return Hooks{k}
 }
 
-func (h Hooks) AfterProposalSubmission(ctx sdk.Context, proposalID uint64) {}
-func (h Hooks) AfterProposalDeposit(ctx sdk.Context, proposalID uint64, depositorAddr sdk.AccAddress) {
+func (h Hooks) AfterProposalSubmission(_ sdk.Context, _ uint64) {}
+func (h Hooks) AfterProposalDeposit(_ sdk.Context, _ uint64, _ sdk.AccAddress) {
 }
 
 func (h Hooks) AfterProposalVote(ctx sdk.Context, proposalID uint64, voterAddr sdk.AccAddress) {
 	h.k.AfterProposalVote(ctx, proposalID, voterAddr)
 }
 
-func (h Hooks) AfterProposalInactive(ctx sdk.Context, proposalID uint64) {}
-func (h Hooks) AfterProposalActive(ctx sdk.Context, proposalID uint64)   {}
+func (h Hooks) AfterProposalInactive(_ sdk.Context, _ uint64) {}
+func (h Hooks) AfterProposalActive(_ sdk.Context, _ uint64)   {}
 
-func (h Hooks) AfterProposalFailedMinDeposit(ctx sdk.Context, proposalID uint64) {}
+func (h Hooks) AfterProposalFailedMinDeposit(_ sdk.Context, _ uint64) {}
 
-func (h Hooks) AfterProposalVotingPeriodEnded(ctx sdk.Context, proposalID uint64) {}
+func (h Hooks) AfterProposalVotingPeriodEnded(_ sdk.Context, _ uint64) {}
 
-func (h Hooks) AfterValidatorCreated(ctx sdk.Context, valAddr sdk.ValAddress) error {
+func (h Hooks) AfterValidatorCreated(_ sdk.Context, _ sdk.ValAddress) error {
 	return nil
 }
 
-func (h Hooks) BeforeValidatorModified(ctx sdk.Context, valAddr sdk.ValAddress) error {
+func (h Hooks) BeforeValidatorModified(_ sdk.Context, _ sdk.ValAddress) error {
 	return nil
 }
 
-func (h Hooks) AfterValidatorRemoved(ctx sdk.Context, consAddr sdk.ConsAddress, valAddr sdk.ValAddress) error {
+func (h Hooks) AfterValidatorRemoved(_ sdk.Context, _ sdk.ConsAddress, _ sdk.ValAddress) error {
 	return nil
 }
 
-func (h Hooks) AfterValidatorBonded(ctx sdk.Context, consAddr sdk.ConsAddress, valAddr sdk.ValAddress) error {
+func (h Hooks) AfterValidatorBonded(_ sdk.Context, _ sdk.ConsAddress, _ sdk.ValAddress) error {
 	return nil
 }
 
-func (h Hooks) AfterValidatorBeginUnbonding(ctx sdk.Context, consAddr sdk.ConsAddress, valAddr sdk.ValAddress) error {
+func (h Hooks) AfterValidatorBeginUnbonding(_ sdk.Context, _ sdk.ConsAddress, _ sdk.ValAddress) error {
 	return nil
 }
 
-func (h Hooks) BeforeDelegationCreated(ctx sdk.Context, delAddr sdk.AccAddress, valAddr sdk.ValAddress) error {
+func (h Hooks) BeforeDelegationCreated(_ sdk.Context, _ sdk.AccAddress, _ sdk.ValAddress) error {
 	return nil
 }
 
-func (h Hooks) BeforeDelegationSharesModified(ctx sdk.Context, delAddr sdk.AccAddress, valAddr sdk.ValAddress) error {
+func (h Hooks) BeforeDelegationSharesModified(_ sdk.Context, _ sdk.AccAddress, _ sdk.ValAddress) error {
 	return nil
 }
 
-func (h Hooks) BeforeDelegationRemoved(ctx sdk.Context, delAddr sdk.AccAddress, valAddr sdk.ValAddress) error {
+func (h Hooks) BeforeDelegationRemoved(_ sdk.Context, _ sdk.AccAddress, _ sdk.ValAddress) error {
 	return nil
 }
 
@@ -90,10 +90,10 @@ func (h Hooks) AfterDelegationModified(ctx sdk.Context, delAddr sdk.AccAddress,
 	return nil
 }
 
-func (h Hooks) BeforeValidatorSlashed(ctx sdk.Context, valAddr sdk.ValAddress, fraction sdk.Dec) error {
+func (h Hooks) BeforeValidatorSlashed(_ sdk.Context, _ sdk.ValAddress, _ sdk.Dec) error {
 	return nil
 }
 
-func (h Hooks) AfterUnbondingInitiated(ctx sdk.Context, id uint64) error {
+func (h Hooks) AfterUnbondingInitiated(_ sdk.Context, _ uint64) error {
 	return nil
 }
diff --git a/x/airdrop/keeper/keeper.go b/x/airdrop/keeper/keeper.go
@@ -58,7 +58,7 @@ func (k Keeper) Logger(ctx sdk.Context) log.Logger {
 	return ctx.Logger().With("module", fmt.Sprintf("x/%s", types.ModuleName))
 }
 
-func (k Keeper) GetAirdropAccount(ctx sdk.Context) sdk.AccAddress {
+func (k Keeper) GetAirdropAccount(_ sdk.Context) sdk.AccAddress {
 	return k.AuthKeeper.GetModuleAddress(types.ModuleName)
 }
 

diff --git a/x/icacallbacks/module_ibc.go b/x/icacallbacks/module_ibc.go
@@ -76,11 +76,11 @@ func (im IBCModule) OnTimeoutPacket(
 }
 
 func (im IBCModule) NegotiateAppVersion(
-	ctx sdk.Context,
-	order channeltypes.Order,
-	connectionID string,
-	portID string,
-	counterparty channeltypes.Counterparty,
+	_ sdk.Context,
+	_ channeltypes.Order,
+	_ string,
+	_ string,
+	_ channeltypes.Counterparty,
 	proposedVersion string,
 ) (version string, err error) {
 	return proposedVersion, nil
@@ -92,24 +92,24 @@ func (im IBCModule) NegotiateAppVersion(
 
 // OnChanCloseConfirm implements the IBCModule interface.
 func (im IBCModule) OnChanCloseConfirm(
-	ctx sdk.Context,
-	portID,
-	channelID string,
+	_ sdk.Context,
+	_,
+	_ string,
 ) error {
 	// icacontroller calls OnChanCloseConfirm but doesn't call the underlying app's OnChanCloseConfirm callback.
 	return nil
 }
 
 // OnChanOpenTry implements the IBCModule interface.
 func (im IBCModule) OnChanOpenTry(
-	ctx sdk.Context,
-	order channeltypes.Order,
-	connectionHops []string,
-	portID,
-	channelID string,
-	chanCap *capabilitytypes.Capability,
-	counterparty channeltypes.Counterparty,
-	counterpartyVersion string,
+	_ sdk.Context,
+	_ channeltypes.Order,
+	_ []string,
+	_,
+	_ string,
+	_ *capabilitytypes.Capability,
+	_ channeltypes.Counterparty,
+	_ string,
 ) (string, error) {
 	panic("UNIMPLEMENTED")
 }

diff --git a/x/millions/keeper/keeper_blockers.go b/x/millions/keeper/keeper_blockers.go
@@ -58,7 +58,7 @@ func (k Keeper) BlockPoolUpdates(ctx sdk.Context) (successCount, errorCount int)
 			"nbr_error", errorCount,
 		)
 	}
-	return
+	return successCount, errorCount
 }
 
 // BlockPrizeUpdates runs all prize updates (clawback)
@@ -114,7 +114,7 @@ func (k Keeper) BlockPrizeUpdates(ctx sdk.Context) (successCount, errorCount int
 			"nbr_error", errorCount,
 		)
 	}
-	return
+	return successCount, errorCount
 }
 
 // BlockWithdrawalUpdates runs all matured withdrawals updates (transfer post unbonding)
@@ -161,5 +161,5 @@ func (k Keeper) BlockWithdrawalUpdates(ctx sdk.Context) (successCount, errorCoun
 			"nbr_error", errorCount,
 		)
 	}
-	return
+	return successCount, errorCount
 }
diff --git a/x/millions/types/pool.go b/x/millions/types/pool.go
@@ -144,7 +144,7 @@ func (p *Pool) ComputeSplitDelegations(_ sdk.Context, amount math.Int) (splits [
 		return nil
 	}
 
-	return
+	return splits
 }
 
 // ComputeSplitUndelegations compute the undelegation split to enforce based on the bonded validators in the set
@@ -216,7 +216,7 @@ func (p *Pool) ComputeSplitUndelegations(_ sdk.Context, amount math.Int) (splits
 		return nil
 	}
 
-	return
+	return splits
 }
 
 func (p *Pool) ApplySplitDelegate(_ sdk.Context, splits []*SplitDelegation) {