Skip to content

Commit

Permalink
Revert "fix(breadcrumb): allow special characters on labels (#3469)" (#…
Browse files Browse the repository at this point in the history
…3484)

* Revert "fix(breadcrumb): allow special characters on labels (#3469)"

This reverts commit 3b544bb.

* chore: revert some eyes settings

* ci: wait on Carousel

---------

Co-authored-by: Bruno Henriques <zettca@users.noreply.github.com>
  • Loading branch information
zettca and zettca committed Jul 4, 2023
1 parent bc0747e commit 268099f
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 7 deletions.
7 changes: 2 additions & 5 deletions .config/applitools.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ module.exports = {

puppeteerOptions: {
args: ["--no-sandbox", "--disable-setuid-sandbox"],
ignoreHTTPSErrors: true,
},

appName: process.env.APPLITOOLS_APP_NAME,
Expand All @@ -24,9 +25,5 @@ module.exports = {

include: ({ kind }) => !isExcludedPath(kind),

testConcurrency: 10,

disableBrowserFetching: true,

showLogs: true,
testConcurrency: 20,
};
3 changes: 2 additions & 1 deletion packages/core/src/components/BreadCrumb/BreadCrumb.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { clsx } from "clsx";
import isNil from "lodash/isNil";
import startCase from "lodash/startCase";
import { isValidElement, MouseEvent } from "react";
import { HvBaseProps } from "@core/types/generic";
import { HvDropDownMenuProps } from "@core/components";
Expand Down Expand Up @@ -122,7 +123,7 @@ export const HvBreadCrumb = ({
)}
variant="body"
>
{removeExtension(elem.label)}
{startCase(removeExtension(elem.label))}
</StyledTypography>
)) || (
<HvPage
Expand Down
3 changes: 2 additions & 1 deletion packages/core/src/components/BreadCrumb/Page/Page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {
HvTypography,
} from "@core/components";
import { ExtractNames } from "@core/utils";
import startCase from "lodash/startCase";
import { MouseEvent } from "react";
import { staticClasses, useClasses } from "./Page.styles";

Expand Down Expand Up @@ -41,7 +42,7 @@ export const HvPage = ({
className={cx(classes.link, classes.label, classes.a)}
{...others}
>
<HvOverflowTooltip data={elem.label} />
<HvOverflowTooltip data={startCase(elem.label)} />
</HvTypography>
);
};
5 changes: 5 additions & 0 deletions packages/core/src/components/Carousel/Carousel.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ export default {
title: "Widgets/Carousel",
component: HvCarousel,
subcomponents: { HvCarouselSlide },
parameters: {
eyes: {
waitBeforeCapture: 5000,
},
},
} as Meta<typeof HvCarousel>;

export const Main: StoryObj<HvCarouselProps> = {
Expand Down

0 comments on commit 268099f

Please sign in to comment.