fix(TimeAgo): justText value

lumada-design · Jun 23, 2023 · 4b3d159 · 4b3d159
1 parent b2b0128
commit 4b3d159
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/packages/core/src/components/TimeAgo/TimeAgo.test.tsx b/packages/core/src/components/TimeAgo/TimeAgo.test.tsx
@@ -39,3 +39,20 @@ describe("TimeAgo with custom Button element", () => {
     expect(screen.getByRole("button")).toBeVisible();
   });
 });
+
+describe("TimeAgo with justText", () => {
+  it("should render the text", () => {
+    const timestamp = Date.now();
+    render(<HvTimeAgo justText timestamp={timestamp} />);
+
+    expect(screen.getByText("a few seconds")).toBeInTheDocument();
+  });
+
+  it("should not render the custom component", () => {
+    const timestamp = Date.now();
+    render(<HvTimeAgo justText timestamp={timestamp} component="button" />);
+
+    expect(screen.getByText("a few seconds")).toBeInTheDocument();
+    expect(screen.queryByRole("button")).toBeNull();
+  });
+});
diff --git a/packages/core/src/components/TimeAgo/TimeAgo.tsx b/packages/core/src/components/TimeAgo/TimeAgo.tsx
@@ -64,9 +64,10 @@ export const HvTimeAgo = ({
     showSeconds,
   });
 
-  return justText && timestamp ? (
-    <>timeAgo</>
-  ) : (
+  // eslint-disable-next-line react/jsx-no-useless-fragment
+  if (justText && timestamp) return <>{timeAgo}</>;
+
+  return (
     <Component className={clsx(classes?.root, timeAgoClasses.root)} {...others}>
       {!timestamp ? emptyElement : timeAgo}
     </Component>