fix(DatePicker): unnecessary onChange removed when closing picker (#3943

)

* fix(DatePicker): unnecessary onChange removed when closing picker

* test(DatePicker): add test

packages/core/src/DatePicker/DatePicker.test.tsx

@@ -1,4 +1,4 @@
-import { describe, expect, it } from "vitest";
+import { describe, expect, it, vi } from "vitest";
 import { fireEvent, render, screen } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 
@@ -90,6 +90,22 @@ describe("HvDatePicker", () => {
       expect(datePickerDropdownValue.length).toBe(1);
       expect(dateInput).toBeInTheDocument();
     });
+    it("should not call onChange when closing", async () => {
+      const onChangeSpy = vi.fn();
+      render(<HvDatePicker onChange={onChangeSpy} />);
+
+      let picker = screen.getByRole("combobox");
+
+      await userEvent.click(picker);
+
+      expect(picker).toHaveAttribute("aria-expanded", "true");
+
+      await userEvent.click(document.body);
+
+      picker = screen.getByRole("combobox");
+      expect(picker).toHaveAttribute("aria-expanded", "false");
+      expect(onChangeSpy).not.toHaveBeenCalled();
+    });
   });
 
   describe("ranged calendar", () => {

packages/core/src/DatePicker/DatePicker.tsx

@@ -312,10 +312,7 @@ export const HvDatePicker = forwardRef<HTMLDivElement, HvDatePickerProps>(
     };
 
     const handleCalendarClose = () => {
-      const shouldSave = !(rangeMode || showActions);
-      if (shouldSave) {
-        handleApply();
-      } else {
+      if (rangeMode || showActions) {
         handleCancel();
       }
     };