Skip to content

Commit

Permalink
fix: table settings story a11y issues
Browse files Browse the repository at this point in the history
  • Loading branch information
plagoa authored and MEsteves22 committed Mar 19, 2024
1 parent 2cb3c4b commit e293856
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ const ColumnItem = ({ item }: { item: Column }) => {
}}
{...attributes}
{...listeners}
role="listitem"
>
{item.title}
<Drag />
Expand Down Expand Up @@ -184,7 +185,7 @@ const ColumnGroup = ({
</div>
)}
{columns.length > 0 && (
<HvListContainer selectable>
<HvListContainer selectable role="list">
<SortableContext items={columnsIds}>
{columns &&
columns.map((col) => <ColumnItem key={col.id} item={col} />)}
Expand Down Expand Up @@ -421,7 +422,7 @@ const SettingsDialog = ({

export const TableSettings = () => {
const tableColumns = useMemo(() => getColumns(), []);
const [popperOpen, setPopperOpen] = useState(false);
const [popperOpen, setPopperOpen] = useState(true);
const data = useMemo(() => makeData(5), []);
const [columnOrder, setColumnOrder] = useState(tableColumns.map((c) => c.id));
const [hiddenColumns, setHiddenColumns] = useState<string[]>([]);
Expand Down

0 comments on commit e293856

Please sign in to comment.