Skip to content

Commit

Permalink
feat(flow): address items configuration
Browse files Browse the repository at this point in the history
- inject data.nodeLabel onDrop
- make subtitle prop override data.nodeLabel
  • Loading branch information
zettca committed May 14, 2024
1 parent c7864b8 commit ee934b2
Show file tree
Hide file tree
Showing 41 changed files with 278 additions and 346 deletions.
34 changes: 4 additions & 30 deletions apps/app/src/pages/Flow/Flow.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Suspense, useEffect, useMemo, useState } from "react";
import { Suspense, useEffect, useState } from "react";
import {
HvButton,
HvGlobalActions,
Expand All @@ -17,14 +17,14 @@ import {
HvFlowSidebar,
} from "@hitachivantara/uikit-react-lab";

import { baseNodeTypes, edges, nodeGroups, nodes } from "./config";
import { edges, nodes, nodeTypes, useNodeGroups } from "./config";
import {
DASHBOARDS_STORAGE_KEY,
DashboardSpecs,
DashboardsStorage,
LAYOUT_COLS,
} from "./types";
import { buildLayout, createDataset, useDatasets } from "./utils";
import { buildLayout } from "./utils";

/** Initial Layout */
const layout = [
Expand All @@ -40,7 +40,7 @@ type Node = NonNullable<ReturnType<HvFlowInstance["getNode"]>>;
type Edge = NonNullable<ReturnType<HvFlowInstance["getEdge"]>>;

const Content = () => {
const { data } = useDatasets();
const nodeGroups = useNodeGroups();

const [reactFlowInstance, setReactFlowInstance] = useState<HvFlowInstance>();
const [open, setOpen] = useState(false);
Expand Down Expand Up @@ -100,32 +100,6 @@ const Content = () => {
};
}, []);

const nodeTypes = useMemo(() => {
const nt: HvFlowProps["nodeTypes"] = { ...baseNodeTypes };

if (data) {
for (let i = 0; i < data.length; i++) {
const key = `dataset${data[i].id}`;

const Dataset = createDataset({
label: data[i].label,
description: data[i].label,
data: {
endpoint: data[i].url,
columns: data[i].columns.map((column) => ({
id: column,
label: column,
})),
},
});

nt[key] = Dataset;
}
}

return nt;
}, [data]);

const handleEdgesChange: HvFlowProps["onEdgesChange"] = (changes) => {
if (changes[0].type === "remove") {
const removedEdged = reactFlowInstance?.getEdge(changes[0].id);
Expand Down
1 change: 0 additions & 1 deletion apps/app/src/pages/Flow/Nodes/BarChart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ export const BarChart: HvFlowNodeFC<NodeData> = (props) => {
<HvFlowNode
description="Bar Chart"
groupId="visualization"
groupItem="barChart"
params={params}
expanded
inputs={[
Expand Down
4 changes: 1 addition & 3 deletions apps/app/src/pages/Flow/Nodes/Dashboard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import {
DashboardsStorage,
NodeData,
} from "../types";

import { toTitleCase } from "../utils";

type PreviewProps = {
Expand Down Expand Up @@ -109,8 +108,7 @@ export const Dashboard: HvFlowNodeFC<NodeData> = (props) => {
return (
<HvFlowNode
description="Dashboard"
group="dashboard"
groupItem="dashboard"
groupId="dashboard"
inputs={nodeInputs}
classes={{
footerContainer: classes.footer,
Expand Down
12 changes: 12 additions & 0 deletions apps/app/src/pages/Flow/Nodes/Dataset.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { HvFlowNode, HvFlowNodeFC } from "@hitachivantara/uikit-react-lab";

export const Dataset: HvFlowNodeFC = (props) => {
return (
<HvFlowNode
title="Dataset"
groupId="dataset"
outputs={[{ label: "Dataset", isMandatory: true, provides: "dataset" }]}
{...props}
/>
);
};
3 changes: 1 addition & 2 deletions apps/app/src/pages/Flow/Nodes/DonutChart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ export const DonutChart: HvFlowNodeFC = (props) => {
return (
<HvFlowNode
description="Donut Chart"
group="visualization"
groupItem="donutChart"
groupId="visualization"
params={params}
expanded
inputs={[
Expand Down
3 changes: 1 addition & 2 deletions apps/app/src/pages/Flow/Nodes/Kpi.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ export const Kpi: HvFlowNodeFC = (props) => {
return (
<HvFlowNode
description="KPI"
group="visualization"
groupItem="kpi"
groupId="visualization"
params={params}
expanded
inputs={[
Expand Down
3 changes: 1 addition & 2 deletions apps/app/src/pages/Flow/Nodes/LineChart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ export const LineChart: HvFlowNodeFC = (props) => {
return (
<HvFlowNode
description="Line Chart"
group="visualization"
groupItem="lineChart"
groupId="visualization"
params={params}
expanded
inputs={[
Expand Down
3 changes: 1 addition & 2 deletions apps/app/src/pages/Flow/Nodes/Table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ export const Table: HvFlowNodeFC = (props) => {
return (
<HvFlowNode
description="Table"
group="visualization"
groupItem="table"
groupId="visualization"
params={params}
expanded
inputs={[
Expand Down
6 changes: 0 additions & 6 deletions apps/app/src/pages/Flow/Nodes/index.ts

This file was deleted.

0 comments on commit ee934b2

Please sign in to comment.