Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breadcrumb): allow special characters #3469

Merged
merged 1 commit into from
Jun 28, 2023
Merged

fix(breadcrumb): allow special characters #3469

merged 1 commit into from
Jun 28, 2023

Conversation

zettca
Copy link
Member

@zettca zettca commented Jun 28, 2023

  • remove startCase to allow special characters to be passed. still converts to start-case

@zettca zettca requested a review from a team as a code owner June 28, 2023 09:49
@zettca zettca requested review from plagoa and MEsteves22 and removed request for a team June 28, 2023 09:49
@github-actions github-actions bot temporarily deployed to uikit/pr-3469 June 28, 2023 10:07 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-3469 June 28, 2023 10:07 Destroyed
@zettca zettca linked an issue Jun 28, 2023 that may be closed by this pull request
2 tasks
@zettca zettca merged commit 3b544bb into master Jun 28, 2023
4 of 5 checks passed
@zettca zettca deleted the fix/breadcrumb branch June 28, 2023 11:43
zettca added a commit that referenced this pull request Jul 3, 2023
zettca added a commit that referenced this pull request Jul 3, 2023
Co-authored-by: Bruno Henriques <zettca@users.noreply.github.com>
MEsteves22 added a commit that referenced this pull request Jul 3, 2023
zettca added a commit that referenced this pull request Jul 3, 2023
MEsteves22 pushed a commit that referenced this pull request Jul 4, 2023
…3484)

* Revert "fix(breadcrumb): allow special characters on labels (#3469)"

This reverts commit 3b544bb.

* chore: revert some eyes settings

* ci: wait on Carousel

---------

Co-authored-by: Bruno Henriques <zettca@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Breadcrumb] Label removing symbols
3 participants