Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Card): add Pentaho Card component #4243

Merged
merged 6 commits into from
Aug 1, 2024
Merged

feat(Card): add Pentaho Card component #4243

merged 6 commits into from
Aug 1, 2024

Conversation

plagoa
Copy link
Contributor

@plagoa plagoa commented Jul 24, 2024

No description provided.

@plagoa plagoa requested a review from a team as a code owner July 24, 2024 16:06
@plagoa plagoa requested review from HQFOX and MEsteves22 and removed request for a team July 24, 2024 16:06
@plagoa plagoa marked this pull request as draft July 24, 2024 16:06
@github-actions github-actions bot temporarily deployed to uikit/pr-4243 July 24, 2024 16:09 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4243 July 24, 2024 16:09 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4243 July 25, 2024 10:08 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4243 July 25, 2024 10:09 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4243 July 25, 2024 13:09 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4243 July 25, 2024 13:10 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4243 July 25, 2024 15:41 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4243 July 25, 2024 15:41 Destroyed
@plagoa plagoa self-assigned this Jul 26, 2024
MEsteves22
MEsteves22 reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@MEsteves22 MEsteves22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice 🙏

I just have the following comments (nothing major):

packages/pentaho/src/Card/stories/ButtonCard.tsx Outdated Show resolved Hide resolved
packages/pentaho/src/Card/stories/ButtonCard.tsx Outdated Show resolved Hide resolved
packages/pentaho/src/Card/stories/ImageCard.tsx Outdated Show resolved Hide resolved
packages/pentaho/src/Card/stories/SimpleCard.tsx Outdated Show resolved Hide resolved
packages/pentaho/src/Card/stories/Stack.tsx Outdated Show resolved Hide resolved
packages/pentaho/src/Card/index.ts Show resolved Hide resolved
packages/pentaho/src/Card/CardMedia/CardMedia.tsx Outdated Show resolved Hide resolved
packages/pentaho/src/Card/Card.stories.tsx Show resolved Hide resolved
packages/pentaho/src/Card/Card.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to uikit/pr-4243 July 26, 2024 16:19 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4243 July 26, 2024 16:20 Destroyed
@plagoa plagoa marked this pull request as ready for review July 26, 2024 17:18
@github-actions github-actions bot temporarily deployed to uikit/pr-4243 July 26, 2024 17:21 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4243 July 26, 2024 17:21 Destroyed
MEsteves22
MEsteves22 approved these changes Jul 29, 2024
View reviewed changes
packages/pentaho/src/Card/CardMedia/CardMedia.tsx Outdated Show resolved Hide resolved
packages/pentaho/src/Card/Card.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to uikit/pr-4243 July 29, 2024 09:16 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4243 July 29, 2024 09:17 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4243 July 29, 2024 09:40 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4243 July 29, 2024 09:40 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4243 July 29, 2024 13:13 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4243 July 29, 2024 16:11 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4243 July 29, 2024 16:11 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4243 July 30, 2024 09:50 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4243 July 30, 2024 09:50 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4243 July 30, 2024 10:41 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4243 July 30, 2024 10:41 Destroyed
@HQFOX
Copy link
Contributor

HQFOX commented Jul 30, 2024

I have noticed that because the component has the same name as the other card component. If you set default theme props for one they will be set for both. Right now it is not problematic because we don't have any overrides in the pentaho theme but it might be in the future.

@MEsteves22
Copy link
Contributor

MEsteves22 commented Jul 30, 2024 •
edited
Loading

I have noticed that because the component has the same name as the other card component. If you set default theme props for one they will be set for both. Right now it is not problematic because we don't have any overrides in the pentaho theme but it might be in the future.

This is a good point 🙏 we should probably discuss about that before merging this PR

@github-actions github-actions bot temporarily deployed to uikit/pr-4243 August 1, 2024 10:23 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4243 August 1, 2024 10:24 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4243 August 1, 2024 10:42 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4243 August 1, 2024 10:43 Destroyed
@MEsteves22 MEsteves22 merged commit b5e5ebb into master Aug 1, 2024
9 of 10 checks passed
@MEsteves22 MEsteves22 deleted the feat/pentaho_card branch August 1, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HQFOX HQFOX HQFOX approved these changes

@MEsteves22 MEsteves22 MEsteves22 approved these changes

Assignees

@plagoa plagoa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@plagoa @HQFOX @MEsteves22