Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Update URL in CLI #175

Closed
fxrysh opened this issue Mar 2, 2022 · 4 comments
Closed

[BUG]: Update URL in CLI #175

fxrysh opened this issue Mar 2, 2022 · 4 comments

Comments

@fxrysh
Copy link

fxrysh commented Mar 2, 2022

As you can see here, all the URL uses lumeland.github.io as the domain which later redirect to lume.land. Instead of using this, maybe change to the lume.land domain instead.

@fxrysh
Copy link
Author

fxrysh commented Mar 2, 2022

There's also a bug(?) on the redirecting method. Instead of redirecting to the current page I'm viewing, I'll always get redirected to the home page.

https://lumeland.github.io/              -> https://lume.land/
https://lumeland.github.io/some-path/    -> https://lume.land/
https://lumeland.github.io/some/path/    -> https://lume.land/

NOTE: I'm not sure if this "bug" is intentional or not.

@fxrysh
Copy link
Author

fxrysh commented Mar 2, 2022

Also, the VSCode configuration file(s) generated by Lume CLI contains some error.

{
  "version": "0.2.0",
  "configurations": [
    {
      // ...
      "program": "https:/deno.land/x/lume@v1.6.3/cli.ts",
      // ERROR: Shouldn't it be `https://` ?
      //                               ^^
      //                      Double forward slash
      
      "cwd": "${workspaceFolder}",
      "runtimeExecutable": "deno",
      // ...
    }
  ]
}

@oscarotero
Copy link
Member

Hi. Yes, you're right. I just released the new lume.land domain yesterday but didn't change this in Lume.
I'll do asap. Thanks!

oscarotero added a commit that referenced this issue Mar 2, 2022
@oscarotero
Copy link
Member

Fixed in v1.6.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants