Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot copy nested directory starting with underscore prefix #520

Closed
Maluscat opened this issue Dec 2, 2023 · 2 comments
Closed

Cannot copy nested directory starting with underscore prefix #520

Maluscat opened this issue Dec 2, 2023 · 2 comments

Comments

@Maluscat
Copy link

Maluscat commented Dec 2, 2023

Version: Lume v1.19.4
OS: Arch Linux

site.copy fails when trying to copy a directory hierarchy starting with an underscored folder:

site.copy('_lib/someLibrary/css/', 'lib');

All files inside _lib/someLibrary/css/ should get copied over into the _site/lib/ folder. Instead, no files will get copied over whatsoever.

When the initial folder is not prefixed with an underscore, the sites are copied over as expected (but then, potential page files like .md or .html will get rendered, which is not the desired behavior).

As is written in the docs, copying a single underscored folder works just fine, for example:

site.copy('_static', '.'); // Works as expected
@oscarotero
Copy link
Member

oscarotero commented Dec 3, 2023

When Lume traverses the source folder and find a folder that must be ignored (like those starting with an underscore), doesn't enter in this folder.
But you have a fair use case. I'll fix it. Thanks

oscarotero added a commit that referenced this issue Dec 4, 2023
@oscarotero
Copy link
Member

Fixed in Lume 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants