Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picture plugin doesn't optimize image #526

Closed
cawa-93 opened this issue Dec 10, 2023 · 2 comments
Closed

Picture plugin doesn't optimize image #526

cawa-93 opened this issue Dec 10, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@cawa-93
Copy link
Contributor

cawa-93 commented Dec 10, 2023 •
edited
Loading

Version

2.0.0

Platform

Windows 11

What steps will reproduce the bug?

  1. Clone repo https://github.com/cawa-93/dotore-website/tree/e1b128b8cb6020cd8892175c5d7573487048e6ca
  2. Run deno task serve
  3. Open site.

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

Main page contain <picture> tag with .webp source.

What do you see instead?

Raw <img> tag with transform-images attribute

Additional information

No response
@cawa-93 cawa-93 added the bug Something isn't working label Dec 10, 2023
@oscarotero
Copy link
Member

Thanks!
It's a bug in picture plugin, that is using the wrong attribute name: https://github.com/lumeland/lume/blob/main/plugins/picture.ts#L50

I'll fix it asap.

oscarotero added a commit that referenced this issue Dec 10, 2023
@oscarotero
fixed attribute name in picture plugin #526
3279ab0
@oscarotero
Copy link
Member

Fixed in Lume v2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oscarotero @cawa-93