Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add RSS plugin #413

Merged
merged 10 commits into from Apr 20, 2023
Merged

add RSS plugin #413

merged 10 commits into from Apr 20, 2023

Conversation

adb-sh
Copy link
Contributor

@adb-sh adb-sh commented Apr 18, 2023

Description

Adding a RSS plugin by making use of the search plugin.

Check List

  • Have you read the
    CODE OF CONDUCT
  • Have you read the document
    CONTRIBUTING
    • One pull request per feature. If you want to do more than one thing,
      send multiple pull request.
    • Write tests.
    • Run deno fmt to fix the code format before commit.
    • Document any change in the CHANGELOG.md.

oscarotero
oscarotero requested changes Apr 19, 2023
View reviewed changes
Copy link
Member

@oscarotero oscarotero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Definitelly, a RSS plugin would be very useful. I just left some comments. I also think it would be nice to configure the RSS format (ATOM, JSON FEED) or just generate both files automatically.

plugins/rss.ts Outdated Show resolved Hide resolved
plugins/rss.ts Outdated Show resolved Hide resolved
plugins/rss.ts Outdated Show resolved Hide resolved
plugins/rss.ts Outdated Show resolved Hide resolved
plugins/rss.ts Outdated Show resolved Hide resolved
plugins/rss.ts Outdated Show resolved Hide resolved
@oscarotero oscarotero merged commit e09856c into lumeland:master Apr 20, 2023
3 checks passed
@oscarotero
Copy link
Member

Thank you!

weakish added a commit to weakish/weakish.github.com that referenced this pull request Apr 23, 2023
@weakish
💤 temporarily commit generated rss
e1a9f3c 
since a rss plugin will be available in the next release

lumeland/lume#413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscarotero oscarotero oscarotero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adb-sh @oscarotero