Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin/fff): fix getGitDate priority #603

Merged
merged 2 commits into from Apr 29, 2024
Merged

fix(plugin/fff): fix getGitDate priority #603

merged 2 commits into from Apr 29, 2024

Conversation

kwaa
Copy link
Member

@kwaa kwaa commented Apr 29, 2024 •
edited

Description

This PR fixes the FFF plugin's getGitDate function to only get the value from git if it is not detected.

Related Issues

Check List

  • Have you read the
    CODE OF CONDUCT
  • Have you read the document
    CONTRIBUTING
    • One pull request per feature. If you want to do more than one thing,
      send multiple pull request.
    • Write tests.
    • Run deno fmt to fix the code format before commit.
    • Document any change in the CHANGELOG.md.

@oscarotero oscarotero merged commit ca33ca8 into main Apr 29, 2024
0 of 6 checks passed
@oscarotero
Copy link
Member

Thanks! the failing test are not related with this (it's weird because tests are passed in my computer)

@oscarotero oscarotero deleted the fix/fff branch April 29, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwaa @oscarotero