Optionally support async render functions for JSX pages #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarotero
requested changes
May 2, 2021
|
Good catch, thanks for this! |
Since `await` can already handle non-`Promise` values, we don't need to actually explicitly wrap the result in `Promise.resolve(...)` Co-authored-by: Oscar Otero <oom@oscarotero.com>
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like engines already support async
renderfunctions, so I figured it would make sense to enable this functionality for JSX pages. Note that I'm usingawait Promise.resolve(...)as according to the MDN docs, this method can both safely wrap an existing Promise or a regular value. This means that this change should remain backward compatible for normal non-async page functions.