Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore clippy warning when length must be >= 1 #148

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Ignore clippy warning when length must be >= 1 #148

merged 1 commit into from
Oct 12, 2023

Conversation

WhyNotHugo
Copy link
Contributor

Fixes: #120

@WhyNotHugo WhyNotHugo mentioned this pull request Sep 29, 2023
Closed
@WhyNotHugo
Copy link
Contributor Author

CI failures seem unrelated. I think they're due to newly introduced checks in Rust.

I can fix the in a separate PR if you want.

@DmitrySamoylov
Copy link
Contributor

CI failures seem unrelated. I think they're due to newly introduced checks in Rust.

I can fix the in a separate PR if you want.

I will look at it shortly.

@DmitrySamoylov
Copy link
Contributor

Can you please rebase this on main?

@WhyNotHugo
Copy link
Contributor Author

Rebased

@DmitrySamoylov DmitrySamoylov merged commit 7c31c6e into lumeohq:main Oct 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitrySamoylov DmitrySamoylov DmitrySamoylov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace .len() < 1 with .is_empty() in generated code
2 participants
@WhyNotHugo @DmitrySamoylov