Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix tests for pytest>=8.0.0 #617

Merged
merged 1 commit into from Jan 31, 2024
Merged

ci: fix tests for pytest>=8.0.0 #617

merged 1 commit into from Jan 31, 2024

Conversation

JoepVanlier
Copy link
Member

Pytest changed its warning/exception order starting from 8.0.0 (see pytest-dev/pytest#9036).

This updates our tests to pass under the new and old version of pytest.

  • For kymographs, this meant explicitly passing a motion blur parameter such that we don't issue that error instead of what we are looking for.
  • For the dwelltime analysis, we have to make sure we don't get any of the deprecation warnings so that we can see the warning we are testing for.
  • For touchdown, we have to explicitly silence the covariance matrix is undefined error (which actually already tells us that the problem will be non-identifiable i.e. too little data, which is exactly what the test tests for).

After this gets merged, I will merge 1.3 back into main.

pytest changed its warning/exception order starting from 8.0.0 (see pytest-dev/pytest#9036).

This updates our tests to fit the new spec.

For kymographs, this meant explicitly passing a motion blur parameter such that we don't issue that error instead of what we are looking for.
For the dwelltime analysis, we have to make sure we don't get any of the deprecation warnings so that we can see the warning we are testing for.
For touchdown, we have to explicitly silence the covariance matrix is undefined error (which actually already tells us that the problem will be non-identifiable).
Copy link
Contributor

@rpauszek rpauszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JoepVanlier JoepVanlier merged commit 3e6bd1a into release/1.3 Jan 31, 2024
8 checks passed
@JoepVanlier JoepVanlier deleted the unique_warnings branch January 31, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants