Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional parallel invocation in power tuning #104

Closed
wants to merge 2 commits into from
Closed

Optional parallel invocation in power tuning #104

wants to merge 2 commits into from

Conversation

claydanford
Copy link
Contributor

@claydanford claydanford commented Sep 24, 2020 •
edited
Loading

Closes #103

@claydanford
Copy link
Contributor Author

Hi @theburningmonk, Any chance this can get a review?

Kindly,

CRD

theburningmonk
theburningmonk approved these changes Sep 26, 2020
View reviewed changes
Copy link
Collaborator

@theburningmonk theburningmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theburningmonk
Copy link
Collaborator

@claydanford the change looks good to me, but I can't merge this because it doesn't follow conventional commit and our pipeline needs it to work out the next semantic version. Can you resubmit the PR and make sure the commit messages follow the conventional commits format?

theburningmonk
theburningmonk requested changes Sep 26, 2020
View reviewed changes
Copy link
Collaborator

@theburningmonk theburningmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need conventional commit message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theburningmonk theburningmonk theburningmonk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@claydanford @theburningmonk