Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix usage of default-filemanager in lumina-open #17

Closed
wants to merge 2 commits into from
Closed

fix usage of default-filemanager in lumina-open #17

wants to merge 2 commits into from

Conversation

Nanolx
Copy link
Contributor

@Nanolx Nanolx commented Oct 8, 2014

Found one minor mistake in your transistion from desktop-settings to session-settings.

Now if default-filemanager is unset or invalid lumina-fm is used, else default-filemanager is used.

@beanpole135
Copy link
Collaborator

Thanks for finding that!
I just missed removing a couple of the QSettings lines from before.
Now, if the extension is "directory" it will go into the cmdFromUser() function, which reads the default application for the extension and uses it. In the case of a directory, it will default to running "lumina-fm" if there is no default file manager set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants