Fix lumina-support.desktop file

[rezso]

usr/share/applications/lumina-support.desktop: error: key "Terminal" is present in group "Desktop Entry", but the type is "Link" while this key is only valid for type "Application"
usr/share/applications/lumina-support.desktop: error: key "StartupNotify" is present in group "Desktop Entry", but the type is "Link" while this key is only valid for type "Application"
usr/share/applications/lumina-support.desktop: error: key "Categories" is present in group "Desktop Entry", but the type is "Link" while this key is only valid for type "Application"

[beanpole135]

Ok, I can understand removing the Terminal/StartupNotify flags for a Link, but the "Categories" value is actually still necessary so the link shows up in the proper place in the application menu tree. This almost appears to be an oversight in the FreeDesktop Specification[1](since "Link" entries are still not very common), and should probably be addressed upstream in the specs team.

Which utility was giving you these errors by the way? Lumina has it's own internal .desktop file parser, so these extra fields should not be causing any issues with Lumina. Also, the desktop entry has the "OnlyShowIn=Lumina" field set, so no other DE's should even pay attention to this file.

[1] https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s05.html

[rezso]

These errors reported by desktop-file-validate utility. My build system automatically checks the desktop files during building a package.
I can made a patch to accept Lumina as desktop and category, but this is not upstreamed.
About the categories: alternatively, you can use an applications-merged xdg menu, and desktop directory.

[beanpole135]

Ok, I just removed the Terminal/StartupNotify fields, but I left the Categories field in place for now.
Let me know if there is anything else I can do to help this get adopted upstream in the FreeDesktop specs.

b288fd5

[rezso]

Thanks.
Another things: the icon paths are hardcoded in the desktop files. For example:
Icon=/usr/local/share/pixmaps/Lumina-DE.png
The extension not required [The image files must be one of the types: PNG, XPM, or SVG, and the extension must be ".png", ".xpm", or ".svg" (lower case).], and if I set PREFIX to /usr, the Lumina-DE.png will be installed in the /usr/share/pixmaps/ directory (which is a standard icon path).
https://specifications.freedesktop.org/icon-theme-spec/latest/ar01s03.html
So an Icon=Lumina-DE is enough.

[beanpole135]

Good catch!
Fixed!

a3cc82c

[rezso]

Thank you. More fixes about this: #204