add optional usage of hugsql options in bind-connection #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #25
In
bind-connection
I needed to reuse part of the variadic parameterfilenames
to not break backwards compatibility. This feels a bit awkward because the possibility for options is hidden in the code, but we can go with it for simplicity.Another solution would be to offer another differently named function for advanced "bind-connection" use. The signature may look like this:
Since this opens up more design space, I tried to anticipate other advanced behaviors:
bind-connection
in(binding [*ns* 'some.namespace] ...)
(bind-connection *db* (file-seq (io/file (io/resource "seeding"))))
), without wrappingbind-connection
inclojure.core/apply
.So an advanced "bind-connection" function might also look like:
Any preferences?
After we settled for a solution I can also add a test case for it.