Use less custom plumbing code in kee-frame template #392
Conversation
…ng kee-frame route sub.
| (assoc db ::route route))) | ||
|
|
||
| (rf/reg-event-fx | ||
| :nav/route-name |
There was a problem hiding this comment.
I didn't fully understand the purpose of this event, is it a workaround for a bug in kee-frame?
There was a problem hiding this comment.
This just allows to dispatch routes by their names, e.g: {:on-click #(rf/dispatch [:nav/by-route-name :home])}
|
Also, changes here are not tested. How do I test the template locally? |
|
Overall looks good, for testing you can do |
…tit/match-by-name
… use that instead of the custom one.
…ed re-frame-http-fx as dependency on re-frame profile
|
As I said on slack, this is considered done now, with some possible bug fixing and tweaking remaining. Let me know if something seems off, and I'll fix it. I'll test some more after work today. |
|
Tested re-frame and kee-frame generating now, looks good. A suggestion: How about separating pure views into a view.cljs? I think it would make the template structure clearer. |
|
The view split was done in the last commit. Let me know what you think, do we keep it? |
Creating a PR to have a discussion about what this template should contain. I made some changes to illustrate what I'm thinking. See my comments in diff below.