-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test for remove_spikes
#185
Comments
Hello! Just wanted to share that the incriminated test runs fine with my configuration, so I don't think it is an upstream library modification issue: lumispy 0.2.3.dev0 (main branch)
I have python 3.10.9 and numpy 1.23.5. |
Could it be related to the changes in the way random numbers are generated? See hyperspy/hyperspy#3103 |
Ah sorry I just noticed that the tests have been commented out in the code ^^ Indeed it fails on my machine too. Changing they way random is seeded does not really seem to change anything though |
Some recent update to HyperSpy or an upstream library breaks the test for automatic peak removal:
You can see the full output here: https://github.com/LumiSpy/lumispy/actions/runs/4451990112/jobs/7819241076
The smaller of the two artificial peaks is not caught on every run, if the
threshold
isauto
.I commented out line 70 and 85 in
test_cl_spectrum.py
to make the tests run through in #184.Also I set
decimal=4
(instead of5
) in all assertions as it was loosing accuracy on some runs.So far, I have not found why the numerics suddenly seem to be less reliable.
In principle, the function should still run, but it seems to be less robust.
Any idea @jordiferrero or @ericpre
The text was updated successfully, but these errors were encountered: