Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path-related error on FFI call #418

Closed
mwu-tow opened this issue Jun 26, 2019 · 1 comment
Closed

Path-related error on FFI call #418

mwu-tow opened this issue Jun 26, 2019 · 1 comment
Labels
d-hard Difficulty: significant prior knowledge required p-highest Should be completed ASAP

Comments

@mwu-tow
Copy link
Contributor

mwu-tow commented Jun 26, 2019

General Summary

I have encountered this issue when trying to debug a reported issue in Dataframes library, but the error message suggests strongly that DLL lookup might be broken, meaning effectively all our FFI is broken.

Steps to Reproduce

I have latest Dataframes library. I replace Main.luna with the following:

import Dataframes.Table

def main:
    Table.fromColumns []

and run by

luna run --target c:\dev\Dataframes

Expected Result

Program exists successfully.

Actual Result

Using standard library at "C:\\dev\\luna\\stdlib\\"
Running in interpreted mode.
Exception "InvalidAbsDir \"%USERPROFILE%\\\\AppData\\\\Local\\\\Microsoft\\\\WindowsApps\""

The path mentioned in the error message is part of my Path environment variable.

Luna Version

e927f7c

@mwu-tow mwu-tow added Type: Bug p-highest Should be completed ASAP labels Jun 26, 2019
@iamrecursion iamrecursion added Category: Runtime d-hard Difficulty: significant prior knowledge required labels Jun 27, 2019
@mwu-tow
Copy link
Contributor Author

mwu-tow commented Jun 27, 2019

Must be side effect of #412 — but I'd say it mostly just exposed underlying bug.
The %envvar% parts should be substituted on Windows before we use the entries found in PATH. Before that the entry is obviously an invalid path. But having an invalid entry in PATH shouldn't crash the whole lookup either — such entries should be quietly ignored.

@joenash joenash closed this as completed Jun 23, 2020
iamrecursion pushed a commit that referenced this issue Jun 23, 2020
…ing Subset of LSP (beginning) (#418)

* Rename language-server -> runner, add language-server, gateway

* Add entry point --lsp

* Add Gateway, LanguageServer

* Add stab for Initialize

* Add stubs for Initialize, Initialized

* Add GatewayTest

* fix PR

* increase timeout

* merge with master

* fix compilation after merge

* reformat with scalafmt

* Add TODOs

* Add doc for gateway

* Update CONTRIBUTING.md

* Refactor code for PR

* Add Request#response(..)

* Make Initialize, Initialized extractor objects

* Refactor for -> map

* Fix docs

* Remove DerivationConfig

* Make Request, Notification polymorphic

* Add Param.Array, Params.Array

* Replace Decoder#apply -> tryDecode

* Refactor code

* Add docs

* Refactor code

* Refactor code

* Refactor code

* Make gateway a pure actor

* Add client capabilities

* Add server capabilities

* Add docs for capabilities

* Add docs

* Add docs

* Fix Server.Config

* Update doc for Server

* Improve PR

* Rename Protocol -> JsonRpcController

* Add docs

* Fix identation.

* Fix identation

* Fix identation

* Fix identation

* Fix docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d-hard Difficulty: significant prior knowledge required p-highest Should be completed ASAP
Projects
None yet
Development

No branches or pull requests

3 participants