Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot mode is broken #7

Closed
garrett opened this issue Dec 11, 2017 · 2 comments
Closed

Screenshot mode is broken #7

garrett opened this issue Dec 11, 2017 · 2 comments
Labels
Milestone

Comments

@garrett
Copy link

garrett commented Dec 11, 2017

Using the (new to Quantum, aka 57+) screenshot tool from the awesomebar (icon in the URL bar, or in its overflow menu) causes the page to turn completely black, making precise selection of screenshots impossible.

Selecting the screenshot feature

firefox-screenshot-menu

Black background

(In this screenshot, the grey rectangle is the element which the screenshot would be cropped to.)

firefox-screenshot-dark

Correct implementation

The correct implementation has a greyed out background for the out of bounds area and the selected area shows up without a screen. (I'll have to remove the theme and restart Firefox to get a screenshot of the screenshot tool in action.)

@garrett
Copy link
Author

garrett commented Dec 11, 2017

Correct: Hover

When the element is hovered, it is still screened, but not as much as the rest of the background:

firefox-screenshot-hover

Correct: Active

When the element is clicked, it looks like this (fully visible, with handles around it to adjust):

firefox-screenshot-active

@lunakurame
Copy link
Owner

This is because userContent.css overrides Firefox' default page background color:

*|*:root {
	--in-content-page-background: #2e3436 !important;
}

I haven't added a userContent.css file for the light variant yet (it's a bit more tricky since @import doesn't work due to a bug in Electrolysis: https://bugzilla.mozilla.org/show_bug.cgi?id=1416184), so you might as well just delete that file if you're using the light variant. I see the screenshot tool injects a bunch of iframes into the document and they inherit that page background color too. Also I noticed uBlock's element picker has the same problem.

The fix for uBlock is easy, but not for the screenshot tool. I don't see a way to blacklist a specific extension since its ID changes every update and Firefox doesn't support the :has pseudo-class yet, so all I can do is use this regexp: /^moz-extension://.+/blank.html$/ to exclude the screenshot tool's iframe page and hope it doesn't match other extensions.

Anyway, it should be working now. Thanks for reporting this bug and including all those screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants