mesa-lib: Adding optional_depends for wayland. kde and especially plasma #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
are making a slow walk towards this being the default. So we need it here when you compile kde-workspace and plasma. There might be a few other kde modules that can use this but kde-workspace is the one I know of for now and of course plasma.
| @@ -14,6 +14,7 @@ depends presentproto | |||
| depends Mako | |||
| depends nettle | |||
|
|
|||
| optional_depends wayland "" "" "This is needed by various components of Plasma" | |||
There was a problem hiding this comment.
I believe --with-egl-platforms=wayland is a requirement as well. Since we add x11 and drm manually I doubt auto-detection really kicks in.
There was a problem hiding this comment.
Your right Ratler. Couldn't we get by with something like this;
—with-egl-platforms=x11,wayland,drm
|
i guess better is to keep the optional_depend on wayland (xorg-server work without it most times) and in BUILD if waylannd is installed add it to the platforms string. |
|
retest this please |
|
SUCCESS! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
are making a slow walk towards this being the default. So we need it here
when you compile kde-workspace and plasma. There might be a few other kde
modules that can use this but kde-workspace is the one I know of for now
and of course plasma.
Unfortunately mesa does not provide any switches.