Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RosettaClientParams.baseUrl required #8

Closed
rhyslbw opened this issue Dec 13, 2020 · 1 comment · Fixed by #9
Closed

Make RosettaClientParams.baseUrl required #8

rhyslbw opened this issue Dec 13, 2020 · 1 comment · Fixed by #9

Comments

@rhyslbw
Copy link
Contributor

rhyslbw commented Dec 13, 2020

I'll be sure to check this library out in more depth, but my cursory review surfaced a minor but important issue regarding adoption. The fallback to a specific server might be a nice convenience for Lunar clients, but it's a boundary violation, and would be confusing for other implementations. I'd suggest just requiring the value passed in explicitly, and would be happy to open a PR if you agree.

Thanks for the work so far!

@stuartwk
Copy link
Contributor

Hey @rhyslbw thanks for the feedback! I agree, it's a bit less confusing if we simply make the baseUrl required. If you feel like doing a PR, we'd gladly merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants