Break out linting into its own CI workflow #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luacheck isn't platform or Lua version dependant and doesn't need to run as part of every job. Having it in a separate workflow by itself will be simpler, faster, and also provide its status independently of other tests making it easier to review test failures.
alerque
force-pushed
the
lint-ci-job
branch
from
c99614f
to
a1315a6
Compare
Tieske
reviewed
Sep 29, 2020
alerque
force-pushed
the
lint-ci-job
branch
from
876c41a
to
ca6794e
Compare
3 tasks
Tieske
approved these changes
Sep 30, 2020
alerque
force-pushed
the
lint-ci-job
branch
from
ca6794e
to
28f79db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Luacheck isn't platform or Lua version dependant and doesn't need to run as part of every job. Having it in a separate workflow by itself will be simpler, faster, and also provide its status independently of other tests making it easier to review test failures.