fix(utils) nil values in choose(cond, val1, val2) #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation of choose would fail if val1 was falsy. I have fixed this by replacing the "and/or" ternary logic with an if statement. Example of failure: choose(true, nil, "hello") -- returns "hello" choose(true, false, "hello") -- returns "hello" Internally, the evaluated expressions were as follows: true and nil or "hello" -- returns "hello" true and false or "hello" -- returns "hello" This commit updates the logic to be as follows: if true then return nil else return "hello" end -- returns nil if true then return false else return "hello" end -- returns false
Tieske
requested changes
Dec 20, 2022
|
Hey @Tieske - Just updated the changelog and removed the old tests that I added. Let me know if you'd like for me to change anything else. |
|
@broma0 thx! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation of choose would fail if val1 was falsy. I have fixed this by replacing the "and/or" ternary logic with an if statement.
Example of failure:
choose(true, nil, "hello") -- returns "hello"
choose(true, false, "hello") -- returns "hello"
Internally, the evaluated expressions were as follows:
true and nil or "hello" -- returns "hello"
true and false or "hello" -- returns "hello"
This commit updates the logic to be as follows:
if true then return nil else return "hello" end -- returns nil
if true then return false else return "hello" end -- returns false