Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci) change to utfTerminal #698

Merged
merged 1 commit into from
Aug 29, 2022
Merged

chore(ci) change to utfTerminal #698

merged 1 commit into from
Aug 29, 2022

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Aug 29, 2022

to colorize output

@Tieske Tieske enabled auto-merge (squash) August 29, 2022 09:08
@Tieske Tieske disabled auto-merge August 29, 2022 09:08
@alerque
Copy link
Member

alerque commented Aug 29, 2022

Why did the -Xoutput=color not get applied as advertized? Should this change also be made in the Docker image so people using the GH Action version get this output by default?

https://github.com/lunarmodules/busted/blob/master/Dockerfile#L31

I'm not a huge fan of the compressed dot view for CI. It's great for local use but not my favorite is CI. The gtest with color seems like the best default for remote runners.

@Tieske
Copy link
Member Author

Tieske commented Aug 29, 2022

Why did the -Xoutput=color not get applied as advertized?

Because the default outputHandler is "plainTerminal" for non-tty and "utfTerminal" for tty. The busted core hence selects "plainTerminal", which does not support the --Xoutput options (since it's "plain").

The gtest with color seems like the best default for remote runners.

k, I'll update to gtest then

@Tieske
Copy link
Member Author

Tieske commented Aug 29, 2022

we could also move the options to the .busted file, with 2 profiles, one for local (basically default with an empty config) and a new profile ci which has all of these options. Then the only option on the Busted CLI in the CI environment would be busted --run=ci.

@alerque
Copy link
Member

alerque commented Aug 29, 2022

That makes sense. If I understand what you are suggesting that just gives us two profiles for testing this project, it doesn't help other projects using the GH Action though correct? So we'd still want to configure some default arguments, probably in the Dockerfile invocation where I linked to but we could potentially setup arguments to the action that would be easier to configure than overriding the entry point.

Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind about messing with Docker in this PR, it seems to have color anyway but possibly for the wrong reasons. I'll look into it separately.

@alerque alerque merged commit ad8abbe into master Aug 29, 2022
@alerque alerque deleted the colorize branch August 29, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants